Change KnownResourceStateStyle.Warn state string from 'warn' to 'warning' #12278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12278Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12278" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a mismatch between the resource state string used in Aspire.Hosting and what the Dashboard expects. The KnownResourceStateStyle.Warn constant was incorrectly set to "warn" but the Dashboard looks for "warning".
Key Changes:
- Updated the
Warnconstant value from"warn"to"warning"to align with Dashboard expectations
Contributor
|
I did try to fix this in #11994 by changing the state int he dashboard, but it caused some test failures so I think changing |
davidfowl
approved these changes
Nov 22, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
KnownResourceStateStylehas a wrong value ofwarn, where the dashboard is expectingwarning. I guess we might want to changeKnownResourceStateStyle.Warnthen also toWarning? Or the other way around and make the dashboard look for"warn"instead of"warning"let me know if you want to change it the other way around.https://github.com/dotnet/aspire/blob/main/src/Aspire.Dashboard/Model/ResourceStateViewModel.cs#L77